qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 00/15]: Initial QObject conversion


From: Luiz Capitulino
Subject: [Qemu-devel] [PATCH v2 00/15]: Initial QObject conversion
Date: Tue, 6 Oct 2009 21:26:57 -0300

 Hi there,

 Here goes another new version of my initial QObject conversion work.

 I'm taking a different approach in this series. Instead of introducing
the error handling code along with the initial conversions, I'm only
doing the QObject conversion part.

 This means that error information is still directly printed by the
command handler, but 'regular' data is returned to the Monitor in the
form of QObjects.

 This approach makes the series easier to:

1. Review, as we can concentrate only on the QObject conversion
2. Convert & merge, as we can do only one thing at a time
3. Test, for the same reason as in '2'

 The disadvantage is that we will need a 'second pass conversion' to
convert the error handling part, which can only be done when I finish
the QError data type I'm writing.

 This is not a big issue anyway, as only two of nine conversions in
this series can fail.

 The following handlers are being converted: do_quit(), do_stop(),
do_system_reset(), do_system_powerdown(), do_cont(), do_balloon(),
do_info_version(), do_info_balloon(), do_info_cpus().

 Also, I'm introducing QList as it's needed by the do_info_cpus()
conversion.

 I've done a full build of this series on F11 (x86_64) and
Debian Lenny (i386), manually tested all conversions and some other
commands.

Changelog:

V1 -> V2:

- Drop error handling code
- More handlers converted

V0 -> V1:

- Introduced MonitorError
- More handlers converted
- Improved patches descriptions
- Minor changes

diffstat:

 Makefile        |    3 +-
 check-qlist.c   |  153 +++++++++++++
 configure       |    2 +-
 monitor.c       |  599 +++++++++++++++++++++++++++++++++++++++---------
 qemu-monitor.hx |  674 ++++++++++++++++++++++++++++++++++++++++++++----------
 qlist.c         |  100 ++++++++
 qlist.h         |   27 +++
 qobject.h       |    8 +-
 8 files changed, 1322 insertions(+), 244 deletions(-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]