[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix |
Date: |
Thu, 24 Sep 2009 22:11:22 +0300 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Thu, Sep 24, 2009 at 08:50:11PM +0300, Blue Swirl wrote:
> On Wed, Sep 23, 2009 at 11:06 PM, Michael S. Tsirkin <address@hidden> wrote:
> > This creates target.c, which builds per-target, and makes it possible
> > for devices to become target-independent. Use it in msix, reverting
> > part of 5e520a7d500ec2569d22d80f9ef4272a34cb3c80, as we no longer have
> > to pass target page around.
>
> > +unsigned target_page_align(unsigned value)
> > +{
> > + return TARGET_PAGE_ALIGN(value);
> > +}
>
> This must be:
> target_phys_addr_t target_page_align(target_phys_addr_t value)
what's the point then? It has to be target independent.
Let's make it unsigned long long, should be good enough.
> As this is not a clean revert anyway, please don't revert the part changing
> if (x)
> y;
> else
> z;
>
> to
>
> if (x) {
> y;
> } else {
> z;
> }
Did I mention I hate this style? But okay :).
--
MST
- [Qemu-devel] [PATCHv2] qemu: target library, use it in msix, Michael S. Tsirkin, 2009/09/23
- [Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix, Blue Swirl, 2009/09/24
- [Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix,
Michael S. Tsirkin <=
- [Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix, Blue Swirl, 2009/09/24
- [Qemu-devel] CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix), Michael S. Tsirkin, 2009/09/29
- [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix), Blue Swirl, 2009/09/29
- [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix), Michael S. Tsirkin, 2009/09/30
- Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix), malc, 2009/09/30
- Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix), Avi Kivity, 2009/09/30
- Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix), Blue Swirl, 2009/09/30
- Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix), Anthony Liguori, 2009/09/30
- Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix), Michael S. Tsirkin, 2009/09/30
- [Qemu-devel] Re: CODING_STYLE, Juan Quintela, 2009/09/30