[Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix)

[Michael S. Tsirkin]

On Tue, Sep 29, 2009 at 09:15:04PM +0300, Blue Swirl wrote:
> On Tue, Sep 29, 2009 at 7:11 PM, Michael S. Tsirkin <address@hidden> wrote:
> > On Thu, Sep 24, 2009 at 11:13:38PM +0300, Blue Swirl wrote:
> >> >> As this is not a clean revert anyway, please don't revert the part 
> >> >> changing
> >> >> if (x)
> >> >>  y;
> >> >> else
> >> >>  z;
> >> >>
> >> >> to
> >> >>
> >> >> if (x) {
> >> >>  y;
> >> >> } else {
> >> >>  z;
> >> >> }
> >> >
> >> > Did I mention I hate this style? But okay :).
> >>
> >> I'm not a great fan of this either, but this is the CODING_STYLE.
> >
> > Maybe we can all vote to change this?
> 
> Actually, I tried to tweak 'indent' to match QEMU style without much success.
> 
> We could also select a new style, like Linux kernel one. I'm also not
> a great fan of that either. But at least 'indent' could be used very
> easily and I think there would be other benefits, like reuse of Git
> hooks, patch checking scripts and Emacs configs. With full 'indent'
> support all sources could be massaged mechanically to make the switch
> less painful.
> 
> Then there are K&R and GNU styles, but I like them even less.

So ... Linux kernel style wins? What do others think?

-- 
MST