|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH 1/2] qemu/qdev: type safety in reset handler |
Date: | Tue, 15 Sep 2009 23:16:42 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 |
On 09/15/2009 10:42 PM, Michael S. Tsirkin wrote:
On Tue, Sep 15, 2009 at 11:20:25PM +0300, Blue Swirl wrote:On Tue, Sep 15, 2009 at 5:33 PM, Michael S. Tsirkin<address@hidden> wrote:Add type safety to qdev reset handlers, by declaring them as DeviceState * rather than void *.The function seems a bit unnecessary,which function?how about instead:instead of which one?static void rtl8139_reset(struct DeviceState *d) { RTL8139State *s = container_of(d, RTL8139State, dev.qdev);
He means not introducing pci_rtl8139_reset. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |