qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] qemu/qdev: type safety in reset handler


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu/qdev: type safety in reset handler
Date: Tue, 15 Sep 2009 23:42:05 +0300
User-agent: Mutt/1.5.19 (2009-01-05)

On Tue, Sep 15, 2009 at 11:20:25PM +0300, Blue Swirl wrote:
> On Tue, Sep 15, 2009 at 5:33 PM, Michael S. Tsirkin <address@hidden> wrote:
> > Add type safety to qdev reset handlers, by declaring them as
> > DeviceState * rather than void *.
> 
> The function seems a bit unnecessary,

which function?

> how about instead:

instead of which one?

> static void rtl8139_reset(struct DeviceState *d)
> {
>     RTL8139State *s = container_of(d, RTL8139State, dev.qdev);
> 
> ?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]