Re: [Qemu-devel] [PATCH] virtio-console: Have a static instance of virtconsole

[Amit Shah]

On (Fri) Sep 04 2009 [19:26:27], Blue Swirl wrote:
> On Fri, Sep 4, 2009 at 12:14 PM, Amit Shah<address@hidden> wrote:
> > Currently the VirtIOConsole struct is allocated from the call
> > to virtio_common_init, also doing an UP_CAST implicitly.
> >
> > The new multiport functionality will need a few arrays and
> > it's easier to move to the new VMState infrastructure by
> > keeping it all within one struct.
> 
> > +VirtIOConsole virtconsole;
> 
> IMHO this is going to wrong direction. What kind of code would need a
> static instance?

Adding multiple ports to the console device, we'll have to store an
array of ports here as well as config space. Both of these are
device-specific.

                Amit