qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] virtio-console: Have a static instance of virt


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH] virtio-console: Have a static instance of virtconsole
Date: Fri, 4 Sep 2009 19:26:27 +0300

On Fri, Sep 4, 2009 at 12:14 PM, Amit Shah<address@hidden> wrote:
> Currently the VirtIOConsole struct is allocated from the call
> to virtio_common_init, also doing an UP_CAST implicitly.
>
> The new multiport functionality will need a few arrays and
> it's easier to move to the new VMState infrastructure by
> keeping it all within one struct.

> +VirtIOConsole virtconsole;

IMHO this is going to wrong direction. What kind of code would need a
static instance?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]