Re: [Qemu-devel] [PATCH 20/24] Add alpha_cpu_list.

[Tristan Gingold]

On Mar 13, 2009, at 6:51 PM, Blue Swirl wrote:

> On 3/13/09, Tristan Gingold <address@hidden> wrote:
> > Add alpha_cpu_list and use cpu_model to select the model in  
> > cpu_alpha_init.
> > Set implver and amask from the model.
> >
> > Signed-off-by: Tristan Gingold <address@hidden>
>
> > +static struct alpha_def alpha_defs[] = {
>
> "const"

Ohh yes.

> > +#if 0
> > +    { "21064", IMPLVER_2106x, 0 },
> > +    { "21164", IMPLVER_21164, 0 },
> > +#endif
> > +    { "21264", IMPLVER_21264, (AMASK_PREFETCH | AMASK_TRAP |  
> > AMASK_BWX
> > +                               | AMASK_FIX) },
> > +    { NULL, 0 }
> > +};
>
> I'd use ARRAY_SIZE macro to determine the size of table for indexing
> instead of no NULL termination, but this style is also widely used.