[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Random MAC address option
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH] Random MAC address option |
Date: |
Tue, 27 Jan 2009 16:33:48 +0000 |
User-agent: |
KMail/1.9.9 |
> + if (strstr(p, "macrandom")) {
I'm not convinced this is a useful feature.
We already allow the user to specify a mac address, so this feature can be
trivially implemented (and better supported) by a management app or simple
shell script.
In addition to the issues other people have raised, there's no validation that
the random value is actually a valid mac address, and no conflict resolution
to avoid duplicate addresses when multiple NICs are present.
Paul
- [Qemu-devel] [PATCH] Replace strcmp() by strncmp(), (continued)