qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Random MAC address option


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Random MAC address option
Date: Tue, 27 Jan 2009 10:47:58 -0600
User-agent: Thunderbird 2.0.0.19 (X11/20090105)

Paul Brook wrote:
+        if (strstr(p, "macrandom")) {

I'm not convinced this is a useful feature.

We already allow the user to specify a mac address, so this feature can be trivially implemented (and better supported) by a management app or simple shell script.

In addition to the issues other people have raised, there's no validation that the random value is actually a valid mac address, and no conflict resolution to avoid duplicate addresses when multiple NICs are present.

I agree.  It gives a false sense of security.

Regards,

Anthony Liguori

Paul







reply via email to

[Prev in Thread] Current Thread [Next in Thread]