[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re:
From: |
Hollis Blanchard |
Subject: |
[Qemu-devel] Re: |
Date: |
Thu, 11 Dec 2008 16:32:45 -0600 |
On Thu, 2008-12-11 at 16:12 -0600, Hollis Blanchard wrote:
> I'm not familiar with this device, but I'm fairly certain the writel handler
> is
> not supposed to recurse.
>
> Signed-off-by: Hollis Blanchard <address@hidden>
>
> diff --git a/hw/ppc405_boards.c b/hw/ppc405_boards.c
> index 4144dae..1d8b6ab 100644
> --- a/hw/ppc405_boards.c
> +++ b/hw/ppc405_boards.c
> @@ -129,9 +129,9 @@ static uint32_t ref405ep_fpga_readl (void *opaque,
> target_phys_addr_t addr)
> static void ref405ep_fpga_writel (void *opaque,
> target_phys_addr_t addr, uint32_t value)
> {
> - ref405ep_fpga_writel(opaque, addr, (value >> 24) & 0xFF);
> - ref405ep_fpga_writel(opaque, addr + 1, (value >> 16) & 0xFF);
> - ref405ep_fpga_writel(opaque, addr + 2, (value >> 8) & 0xFF);
> + ref405ep_fpga_writeb(opaque, addr, (value >> 24) & 0xFF);
> + ref405ep_fpga_writeb(opaque, addr + 1, (value >> 16) & 0xFF);
> + ref405ep_fpga_writeb(opaque, addr + 2, (value >> 8) & 0xFF);
> ref405ep_fpga_writeb(opaque, addr + 3, value & 0xFF);
> }
If git weren't dumb, the subject would have read "Fix 405 FPGA emulation
typo".
--
Hollis Blanchard
IBM Linux Technology Center