[Qemu-devel] Re: [PATCH 2/3] dyngen: fix some warnings about unused functions

[Mark McLoughlin]

On Thu, 2008-11-13 at 13:39 -0600, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > Warnings were:
> >
> >   dyngen.c:292: error: ‘pstrcpy’ defined but not used
> >
> > Only used with CONFIG_FORMAT_COFF
> >
> >   dyngen.c:319: error: ‘swab32ss’ defined but not used
> >
> > With ELF_USES_RELOCA, either swab32ss() or swab64ss() will
> > be used depending on ELF_CLASS. Easier to just mark them
> > both as unused.
> >
> >   dyngen.c:334: error: ‘get16’ defined but not used
> >   dyngen.c:343: error: ‘get32’ defined but not used
> >   dyngen.c:352: error: ‘put16’ defined but not used
> >   dyngen.c:359: error: ‘put32’ defined but not used
> >
> > Maybe be used for some host arches; easiest to mark them as
> > unused.
> >
> >   dyngen.c:425: error: ‘elf_swap_phdr’ defined but not used
> >
> > This one is completely unused; just delete.
> >   
> 
> Since dyngen is going away soon, I'm not eager to make changes to it 
> that could possibly break on some weird architecture.  Do you think it 
> would be terrible to just ignore this for now?

Yeah, that's fine - I was trying to make it possible to build with
--enable-werror to so it would be easier to spot new warnings.

The tcg 'TARGET_LONG_BITS is not defined' warning seems much more nasty
to solve anyway.

Well, slirp too - but you can build with --disable-slirp to get around
that.

Cheers,
Mark.