[Qemu-devel] Re: [PATCH 1/3] x86: fix warning without CONFIG_KVM

[Jan Kiszka]

Mark McLoughlin wrote:
> Warning is:
> 
>  target-i386/helper.c: In function `cpu_x86_cpuid':
>  target-i386/helper.c:1373: warning: implicit declaration of function 
> `host_cpuid'
> 
> Signed-off-by: Mark McLoughlin <address@hidden>
> ---
>  target-i386/helper.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 7ddb4ce..c8b8be9 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1296,10 +1296,10 @@ target_phys_addr_t cpu_get_phys_page_debug(CPUState 
> *env, target_ulong addr)
>  }
>  #endif /* !CONFIG_USER_ONLY */
>  
> -#if defined(CONFIG_KVM)
>  static void host_cpuid(uint32_t function, uint32_t *eax, uint32_t *ebx,
>                         uint32_t *ecx, uint32_t *edx)
>  {
> +#if defined(CONFIG_KVM)
>      uint32_t vec[4];
>  
>  #ifdef __x86_64__
> @@ -1327,8 +1327,8 @@ static void host_cpuid(uint32_t function, uint32_t 
> *eax, uint32_t *ebx,
>       *ecx = vec[2];
>      if (edx)
>       *edx = vec[3];
> -}
>  #endif
> +}

Isn't it cleaner to provide an empty static inline in the !CONFIG_KVM
case? Not all compilers might be smart enough to optimize this function
away.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2 ES-OS
Corporate Competence Center Embedded Linux