Re: [Qemu-devel] [PATCH] add serial port mux for debug monitor support

[Jason Wessel]

Following up to my last patch, I noticed a break; statement was missing 
and cause a bit of a problem with the -echr option.

Fix is attached.

signed-off-by: address@hidden

Jason Wessel wrote:
> There are two patches attached to show the logical progress of the 
> code and in the case that one is not accepted the work is more easily 
> broken down.
>
> The serial_mux_driver.patch must be applied first.  It adds a generic 
> mux support for the I/O drivers internal to vl.c.  The main purpose is 
> to use it for switching on the monitor.  Basically it allows more than 
> one driver to register an fd_read and fd_can_read routine.  Of course 
> the mux support is generic and could easily be used for other sorts of 
> I/O.  This patch also adds the new options:
>
> -echr ascii_value -- Allow you to use a different control character 
> other than Control-a
> -serial mon:device_string  -- Multiplex the device_string with the 
> monitor functionality
>
> The second patch fully abstracts the monitor so that the monitor can 
> be used on more than one serial port at the same time as well as 
> having a separate dedicated monitor.  I also removed the stdio 
> splitting from the stdio driver.  The mux driver can be used to 
> replace any functionality that I missed.
>
> signed-off-by: address@hidden
>
> Jason.

Index: qemu/vl.c
===================================================================
--- qemu.orig/vl.c
+++ qemu/vl.c
@@ -6036,6 +6036,7 @@ int main(int argc, char **argv)
                     term_escape_char = strtol(optarg, &r, 0);
                     if (r == optarg)
                         printf("Bad argument to echr\n");
+                    break;
                 }
             case QEMU_OPTION_monitor:
                 pstrcpy(monitor_device, sizeof(monitor_device), optarg);