Re: [Qemu-devel] Recent patches for qemu block-cow.c etc breaks Win32 build becaus e of fsync()

[Paul Brook]

> > > Why not define it in config-host.mak like this:
> > >
> > > --- configure.old 2006-06-08 23:06:48.000000000 +0200
> > > +++ configure     2006-06-08 23:07:10.000000000 +0200
> > > @@ -102,6 +102,7 @@
> > >  ;;
> > >  MINGW32*)
> > >  mingw32="yes"
> > > +CFLAGS="-Dfsync=_commit"
> > >  ;;
> > >  FreeBSD)
> > >  bsd="yes"
> >
> > No. This is what header files are for.
>
> Yes, but MS did not provide fsync in header files ;-)

I mean you should add a #define in a header file somewhere (eg. vl.h where 
there are already similar things), not do it via a commandline option.

Paul