[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 10/42] job: Add JobDriver.job_type
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 10/42] job: Add JobDriver.job_type |
Date: |
Mon, 14 May 2018 16:12:01 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/11/2018 06:53 PM, Max Reitz wrote:
> On 2018-05-09 18:26, Kevin Wolf wrote:
>> This moves the job_type field from BlockJobDriver to JobDriver.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: John Snow <address@hidden>
>> ---
>> include/block/blockjob_int.h | 3 ---
>> include/qemu/job.h | 11 +++++++++++
>> block/backup.c | 2 +-
>> block/commit.c | 2 +-
>> block/mirror.c | 4 ++--
>> block/stream.c | 2 +-
>> blockjob.c | 16 +++++++---------
>> job.c | 10 ++++++++++
>> 8 files changed, 33 insertions(+), 17 deletions(-)
>>
>
> [...]
>
>> diff --git a/include/qemu/job.h b/include/qemu/job.h
>> index b4b49f19e1..c87e951c8a 100644
>> --- a/include/qemu/job.h
>> +++ b/include/qemu/job.h
>
> [...]
>
>> @@ -57,4 +62,10 @@ struct JobDriver {
>> */
>> void *job_create(const char *job_id, const JobDriver *driver, Error **errp);
>>
>> +/** Returns the JobType of a given Job. */
>> +JobType job_type(Job *job);
>> +
>> +/** Returns the enum string for the JobType of a given Job. */
>> +const char *job_type_str(Job *job);
>> +
>
> Is there a good reason for these not to take a const Job *?
>
> Depending on the answer:
>
> Reviewed-by: Max Reitz <address@hidden>
>
>> #endif
>
Max is just very excited to talk about Rust some more, I can tell.
- [Qemu-block] [PATCH 08/42] job: Create Job, JobDriver and job_create(), (continued)
- [Qemu-block] [PATCH 08/42] job: Create Job, JobDriver and job_create(), Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 09/42] job: Rename BlockJobType into JobType, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 10/42] job: Add JobDriver.job_type, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 11/42] job: Add job_delete(), Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 12/42] job: Maintain a list of all jobs, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 14/42] job: Add reference counting, Kevin Wolf, 2018/05/09