[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 08/42] job: Create Job, JobDriver a
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 08/42] job: Create Job, JobDriver and job_create() |
Date: |
Mon, 14 May 2018 15:57:36 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/09/2018 12:26 PM, Kevin Wolf wrote:
> This is the first step towards creating an infrastructure for generic
> background jobs that aren't tied to a block device. For now, Job only
> stores its ID and JobDriver, the rest stays in BlockJob.
>
> The following patches will move over more parts of BlockJob to Job if
> they are meaningful outside the context of a block job.
>
> Signed-off-by: Kevin Wolf <address@hidden>
I think I'll be reviewing this series in a manner that trusts that all
of the obvious cleanups get handled later, and only yelp if something
looks distinctly wrong.
Anything that simply doesn't get cleaned up is something we can fix
later, so unless it looks like it's painting us into a corner, it
probably doesn't need to be addressed right away.
Reviewed-by: John Snow <address@hidden>
- Re: [Qemu-block] [Qemu-devel] [PATCH 04/42] blockjob: Implement block_job_set_speed() centrally, (continued)
- [Qemu-block] [PATCH 05/42] blockjob: Introduce block_job_ratelimit_get_delay(), Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 06/42] blockjob: Add block_job_driver(), Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 08/42] job: Create Job, JobDriver and job_create(), Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 09/42] job: Rename BlockJobType into JobType, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 10/42] job: Add JobDriver.job_type, Kevin Wolf, 2018/05/09
- [Qemu-block] [PATCH 11/42] job: Add job_delete(), Kevin Wolf, 2018/05/09