[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v15 13/21] iotests: 091: Quit QEMU before checki
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH v15 13/21] iotests: 091: Quit QEMU before checking image |
Date: |
Thu, 27 Apr 2017 15:04:35 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, 04/26 14:34, Kevin Wolf wrote:
> Am 26.04.2017 um 05:34 hat Fam Zheng geschrieben:
> > Signed-off-by: Fam Zheng <address@hidden>
> > Reviewed-by: Max Reitz <address@hidden>
> > ---
> > tests/qemu-iotests/091 | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091
> > index 32bbd56..10ac4a8 100755
> > --- a/tests/qemu-iotests/091
> > +++ b/tests/qemu-iotests/091
> > @@ -95,7 +95,9 @@ echo "vm2: qemu process running successfully"
> > echo "vm2: flush io, and quit"
> > _send_qemu_cmd $h2 'qemu-io disk flush' "(qemu)"
> > _send_qemu_cmd $h2 'quit' ""
> > +_send_qemu_cmd $h1 'quit' ""
> >
> > +wait
>
> I think it's better to use the function from common.qemu for this:
>
> wait=1 _cleanup_qemu
>
I didn't look into it, but that would get such an error:
091 1s ... - output mismatch (see 091.out.bad)
--- /stor/work/qemu/tests/qemu-iotests/091.out 2016-10-27 14:31:53.671300277
+0800
+++ 091.out.bad 2017-04-27 15:03:28.965504185 +0800
@@ -18,6 +18,20 @@
vm2: qemu-io disk write complete
vm2: qemu process running successfully
vm2: flush io, and quit
+total time: 48 milliseconds
+downtime: 25 milliseconds
+setup: 1 milliseconds
+transferred ram: 465 kbytes
+throughput: 99.28 mbps
+remaining ram: 0 kbytes
+total ram: 131592 kbytes
+duplicate: 32854 pages
+skipped: 0 pages
+normal: 44 pages
+normal bytes: 176 kbytes
+dirty sync count: 2
+(qemu) quit
+(qemu) quit
Check image pattern
read 4194304/4194304 bytes at offset 0
4 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
- [Qemu-block] [PATCH v15 07/21] qemu-io: Add --force-share option, (continued)
- [Qemu-block] [PATCH v15 07/21] qemu-io: Add --force-share option, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 08/21] iotests: 030: Prepare for image locking, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 09/21] iotests: 046: Prepare for image locking, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 10/21] iotests: 055: Don't attach the target image already for drive-backup, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 11/21] iotests: 085: Avoid image locking conflict, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 12/21] iotests: 087: Don't attach test image twice, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 13/21] iotests: 091: Quit QEMU before checking image, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 14/21] iotests: 172: Use separate images for multiple devices, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 15/21] tests: Use null-co:// instead of /dev/null as the dummy image, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 16/21] file-posix: Add 'locking' option, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 17/21] tests: Disable image lock in test-replication, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 18/21] block: Reuse bs as backing hd for drive-backup sync=none, Fam Zheng, 2017/04/25