[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v15 16/21] file-posix: Add 'locking' option
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH v15 16/21] file-posix: Add 'locking' option |
Date: |
Thu, 27 Apr 2017 10:29:52 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, 04/26 14:41, Kevin Wolf wrote:
> Am 26.04.2017 um 05:34 hat Fam Zheng geschrieben:
> > Making this option available even before implementing it will let
> > converting tests easier: in coming patches they can specify the option
> > already when necessary, before we actually write code to lock the
> > images.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block/file-posix.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/block/file-posix.c b/block/file-posix.c
> > index ade71db..2114720 100644
> > --- a/block/file-posix.c
> > +++ b/block/file-posix.c
> > @@ -392,6 +392,11 @@ static QemuOptsList raw_runtime_opts = {
> > .type = QEMU_OPT_STRING,
> > .help = "host AIO implementation (threads, native)",
> > },
> > + {
> > + .name = "locking",
> > + .type = QEMU_OPT_BOOL,
> > + .help = "lock the file",
> > + },
> > { /* end of list */ }
> > },
> > };
>
> I don't mind whether it happens in this patch or when the option is
> actually implemented, but this option needs to be added to the QAPI
> schema.
I will add it.
Fam
- Re: [Qemu-block] [PATCH v15 11/21] iotests: 085: Avoid image locking conflict, (continued)
- [Qemu-block] [PATCH v15 12/21] iotests: 087: Don't attach test image twice, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 13/21] iotests: 091: Quit QEMU before checking image, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 14/21] iotests: 172: Use separate images for multiple devices, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 15/21] tests: Use null-co:// instead of /dev/null as the dummy image, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 16/21] file-posix: Add 'locking' option, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 17/21] tests: Disable image lock in test-replication, Fam Zheng, 2017/04/25
- [Qemu-block] [PATCH v15 18/21] block: Reuse bs as backing hd for drive-backup sync=none, Fam Zheng, 2017/04/25
[Qemu-block] [PATCH v15 19/21] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2017/04/25