[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v6 14/16] gdbstub: gdb_set_stop_cpu: ignore reques
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-arm] [PATCH v6 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached |
Date: |
Fri, 16 Nov 2018 11:14:18 +0100 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Thu, Nov 15, 2018 at 10:42:05AM +0100, Luc Michel wrote:
> When gdb_set_stop_cpu() is called with a CPU associated to a process
> currently not attached by the GDB client, return without modifying the
> stop CPU. Otherwise, GDB gets confused if it receives packets with a
> thread-id it does not know about.
>
> Signed-off-by: Luc Michel <address@hidden>
> Acked-by: Alistair Francis <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> gdbstub.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 59eed3b878..89819a6a72 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1787,10 +1787,19 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> return RS_IDLE;
> }
>
> void gdb_set_stop_cpu(CPUState *cpu)
> {
> + GDBProcess *p = gdb_get_cpu_process(gdbserver_state, cpu);
> +
> + if (!p->attached) {
> + /* Having a stop CPU corresponding to a process that is not attached
> + * confuses GDB. So we ignore the request.
> + */
> + return;
> + }
> +
> gdbserver_state->c_cpu = cpu;
> gdbserver_state->g_cpu = cpu;
> }
>
> #ifndef CONFIG_USER_ONLY
> --
> 2.19.1
>
- Re: [Qemu-arm] [PATCH v6 05/16] gdbstub: add multiprocess support to vCont packets, (continued)
- [Qemu-arm] [PATCH v6 06/16] gdbstub: add multiprocess support to 'sC' packets, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 15/16] gdbstub: add multiprocess extension support, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 10/16] gdbstub: add multiprocess support to 'D' packets, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached, Luc Michel, 2018/11/15
- Re: [Qemu-arm] [PATCH v6 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached,
Edgar E. Iglesias <=
- [Qemu-arm] [PATCH v6 09/16] gdbstub: add multiprocess support to gdb_vm_state_change(), Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo, Luc Michel, 2018/11/15
- [Qemu-arm] [PATCH v6 11/16] gdbstub: add support for extended mode packet, Luc Michel, 2018/11/15