Re: [Qemu-arm] [Qemu-devel] [PATCH v2 08/13] hw/misc/tz_mpc.c: Honour the BLK_LUT settings in translate

[Peter Maydell]

On 15 June 2018 at 17:07, Peter Maydell <address@hidden> wrote:
> On 15 June 2018 at 08:31, Auger Eric <address@hidden> wrote:
>> Hi Peter,
>>
>> On 06/04/2018 05:29 PM, Peter Maydell wrote:
>>> The final part of the Memory Protection Controller we need to
>>> implement is actually using the BLK_LUT data programmed by the
>>> guest to determine whether to block the transaction or not.
>>>
>>> Since this means we now change transaction mappings when
>>> the guest writes to BLK_LUT, we must also call the IOMMU
>>> notifiers at that point.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>
>>> +        if (newlut & (1 << i)) {
>> Add a comment saying the block is configured as non-secure?

...actually, how about instead having a new variable
   bool block_is_ns = newlut & (1 << i);

and then here and in the later if() having "if (block_is_ns)" ?
I think that clarifies without needing a comment.

thanks
-- PMM