[Protux-devel] [Fwd: two bugs, with patches]

[Fabio dos Santos]

-----Mensagem encaminhada-----

From: Jeremy Shaw <address@hidden>
To: address@hidden, address@hidden, address@hidden
Subject: two bugs, with patches
Date: 24 Nov 2002 21:56:08 -0800

Hello,

I have "fixed" two bugs I found highly irating, and attached patch
files.

(1) Project.cc.diff

Summary: The second-time you start protux, it does not display the two
songs in the Untitled Project.

Details: The code was trying to convert the string "Numsongs=2" into
an integer via 'atoi', and always got '0'.

Fix: I used QString::remove() to chop off "Numsongs=" and then used
QString::toInt() to convert it to an integer. 

(2) FileBrowser.cc.diff

Summary: if you miss an icon and click on whitespace in the
FileBrowser QtFileIconView the protux seg faults.

Details: QtFileIconView::itemDoubleClicked( QIconViewItem *i)
attempted to dereference 'item' without first checking to see if it
was null.

Fix: if item is a null-pointer, just return.

Notes:
I also changed: 

  QtFileIconViewItem *item = ( QtFileIconViewItem* )i;

to

  QtFileIconViewItem *item = dynamic_cast<QtFileIconViewItem*>(i);

So that the method would not cause a seg-fault if someone attempted to
pass something other than an QtFileIconViewItem. 


Jeremy Shaw.
-- 
Fabio dos Santos <address@hidden>

FileBrowser.cc.diff
Description: Text document