Re: [Phpgroupware-developers] phpgw commits

[Chris Weiss]

Is this for HEAD or .16?  what modules does it affect?

I'm worried about 2 things on the pass by reference, I haven't done
any tests with this:

#1 if a function is defined with references and a call passes by
reference too, what happens?  I'm thinking 3rd party code here, I'm
sure you'll do a thorough job but you don't have access to everything
that uses phpgw code.

#2 if a function is changed to use references when the calling code
doesn't expect it, what kinds of wierd things will happen?   Obviously
this will depends both on what the function does and what the calling
code follows up with.

Call-time pass-by-reference should have been gone long ago, but it's
not and this has the potential to be a major change.

Is anyone running "allow_call_time_pass_reference = Off" without
problems?  If so, what phpgw features are you using?

On 5/4/05, Kai Hofmann <address@hidden> wrote:
> Hi all,
> 
> some small fixes found by php -l (other php.ini settings as well as tested
> with php5)
> have been commited. All commits have been documented via the cvs log and
> should appear
> within the cvscommit mailinglist.
> At the moment it seems that savannahs mailman has some problems.
> 
> General spoken these fixes are as follows:
> 
> - removed variables that have been decalred twice
> - Overriding of $this in apis service class
> - Within calendar application renaming of thre constants because of
>   conflicting with php5 keywords: private and public.
> 
> Still there is one larger fix open that I will do this (long) weekend:
> 
> PHP Warning:  Call-time pass-by-reference has been deprecated - argument
> passed
> by value;  If you would like to pass it by reference, modify the declaration
> of
> [runtime function name]().  If you would like to enable call-time
> pass-by-refere
> nce, you can set allow_call_time_pass_reference to true in your INI file.
> Howev
> er, future versions may not support this any longer.
> 
> Because this is deprecated since more than two years and will not run
> correctly
> when the ini file parameter is not set, I will fix this for the complete
> groupware.
> 
> For more information and examples have a look at:
> 
> http://www.php.net/manual/en/functions.arguments.php#functions.arguments.by- 
> reference
> 
> Greetings
> 
>   PowerStat
> 
> _______________________________________________
> Phpgroupware-developers mailing list
> address@hidden 
> http://lists.gnu.org/mailman/listinfo/phpgroupware-developers 
> 
>