|
From: | Jose E. Marchesi |
Subject: | Re: [pdf-devel] New developer and UUID module request |
Date: | Wed, 16 Mar 2011 20:50:57 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Hi Albert. Please find attached another patch with your suggested modifications (pdf_uuid_t is no longer allocated in the heap). Looks good. Just one question. In the function pdf_uuid_string: +const char * +pdf_uuid_string (pdf_uuid_t uuid) +{ + static char ascii_rep[PDF_UUID_CHAR_LENGTH]; + + uuid_unparse (uuid.uuid, ascii_rep); + + return ascii_rep; +} Is there a specific reason to use the static buffer 'ascii_rep' instead of allocating a new string? That makes pdf_uuid_string non-reentrant.
[Prev in Thread] | Current Thread | [Next in Thread] |