pan-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pan-users] Unwanted header pane refresh in 14.0


From: Per Hedeland
Subject: [Pan-users] Unwanted header pane refresh in 14.0
Date: Sun, 15 Jun 2003 11:54:16 +0200 (CEST)

Hello,

I recently upgraded from 0.13.3 to 0.14.0 (built via FreeBSD ports in
both cases), and while 14.0 in general works great (as always:-), there
is one change between these versions that I find quite annoying:
Whenever you switch layout (e.g. via '3'/'z'), the header pane is
refreshed, including filter application.

I frequently do '3' (jump to body pane) to make better use of screen
real estate when I've found a set of articles that I'm going to read in
sequence (or navigate with 'v'/'n'), and then 'z' to go back to tabbed
layout. Since my filter doesn't match read articles (rather common I
guess), this usage breaks with 14.0: In particular the '3' causes the
read articles, including the current one, to be flushed out - with the
result that the context is lost, and the first <space> in "body pane
mode" goes to the first article in the group instead of the next in the
wanted sequence. And in general, I don't want to "lose" the read
articles until I ask for it. In 13.3, there was no such refresh.

I've dug around in the source a bit to find where this refresh was
initiated, but unsuccessfully - I did the first change below, which
solves the immediate problem for me but is clearly wrong (e.g. the
filter won't be applied on "get new headers", only on initial loading of
the group), and I find the redraw that still happens rather annoying
too.

I'd love to see this behaviour be reverted to the earlier one, or a
preference setting to turn off the refresh - or failing that, I'd
appreciate a pointer to where in the source this refresh is initiated,
so I can disable it in my build (and maybe even provide a patch for a
preference setting if I can figure out how those are done:-).

Thanks
--Per Hedeland

PS The second change below *is* a bugfix, the abbreviated Subject shown
in the download progress indicator includes a character from the middle
of the Subject that shouldn't be there - though it's a *very*
unimportant one...:-)

================

--- pan-0.14.0/pan/articlelist.c.ORIG   Mon Jun  9 11:54:46 2003
+++ pan-0.14.0/pan/articlelist.c        Mon Jun  9 14:05:01 2003
@@ -3090,7 +3090,7 @@
 void
 articlelist_refresh (void)
 {
-       refresh_impl (~0);
+       refresh_impl (~REFRESH_FILTER);
 }
 
 
--- pan-0.14.0/pan/status-item-view.c.ORIG      Mon Jun  9 11:54:46 2003
+++ pan-0.14.0/pan/status-item-view.c   Mon Jun  9 15:24:10 2003
@@ -135,7 +135,7 @@
        g_string_append (tmp, cpch_midpoint);
 
        /* start trimming out the characters next to the ellipses */
-       i = original_midpoint - 1;
+       i = original_midpoint;
        j = original_midpoint + 2; /* "..." */
        for (;;)
        {




reply via email to

[Prev in Thread] Current Thread [Next in Thread]