Re: [Pan-devel] Pan 0.91 issues

[Charles Kerr]

Christophe Lambin wrote:

> Close. You need to make sure the ".\r\n" is on a new line. Changed line
> 441 to:
>   s += "\r\n.\r\n";
> Obviously that's not the right fix, but it did allow the post to go
> through.

Okay.  We can test for a linefeed before appending one:

+++ nntp.cc     2006-04-05 16:28:59.000000000 -0500
@@ -435,6 +435,7 @@
   _listener = l;

   std::string s (msg.str, msg.len);
+  if (s.empty() || s[s.size()-1]!='\n') s += '\n';
   replace_linear (s, "\n.", "\n..");
   replace_linear (s, "\n", "\r\n");
   replace_linear (s, "\r\r\n.", "\r\n");
   s += ".\r\n";

> Now, the article did not show up when I next did 'get new headers', but
> I suspect that's a different bug. It did show up when I got 'all
> headers'.

Well, that's what I'm here for.

cheers,
Charles
(here for fixing the bugs, or for writing them in the first place? ;)