[Octave-patch-tracker] [patch #8943] object class "light" for lighting effects on patches and surfaces

[Markus Mützel]

Follow-up Comment #36, patch #8943 (project octave):

Thank you, Dan, for pointing me to the issues you discovered in bug #48869. I
am answering here to the issue there:

It is probably not necessary to call "get_maxlights" in the constructor of
gl_render. If the current implementation causes problems, it should be
possible to move "get_maxlights" to "draw_axes_children" (see attached
changeset).
I am not seeing any segfaults on the systems where I ran my tests with this
change or before. Can you please test whether this fixes the segfault for
you?
I cannot comment on whether it would make (more) sense to move renderer()
inside of the constructor for OpenGL_fltk. On the one hand, I am not familiar
enough with the fltk code and, on the other hand, I cannot test whether this
would fix the segfault.

Wrt your second question: num_lights counts all lights in the axes and within
(nested) hggroups. The function from which your code snippet originates calls
itself recursively for (nested) hggroups. "num_lights" is still initialized to
0 in draw_axes_children.

(file #38104)
    _______________________________________________________

Additional Item Attachment:

File name: patch8943_max_lights.patch     Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8943>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/