[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Can't define methods on a @datetime class

From: Andrew Janke
Subject: Re: Can't define methods on a @datetime class
Date: Thu, 17 Jan 2019 06:31:14 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/13/19 4:48 PM, Andrew Janke wrote:

On 1/13/19 1:35 PM, Andreas Weber wrote:
Am 12.01.19 um 10:53 schrieb Andrew Janke:
You're welcome, glad to help. If you plan to implement datetime for Octave I would suggest to use to use endfunction, endswitch, endproperties, endmethods and so on for better readability.

-- Andy

Yep, I'll switch the style over to the GNU Octave style before submitting it. I'm just not a fan of that style personally, so I'm going to keep it in Matlab style while it's under development.

My point was that you would have found the problematic end yourself (or at least it would have been easier for me) if you would have used endswitch, endfunction, endmethods. In my eyes this Octave addition is not only "style" but a way to increase readability.

-- Andy

PS: I saw you've removed datetime.m from your repo? Why

Fair point. I'm pretty reliant on Matlab's auto-formatting for the same thing.
I'll consider switching over.

I moved datetime to a separate repo that is now structured as an Octave
pkg project: https://github.com/apjanke/octave-addons-chrono. That'll
make it easier to work with, and make sure dependencies on the other
bits of code (like string/ and misc/) in my main octave-addons don't
creep in to it.


For anyone who's interested, I've got basic datetime, duration, and calendarDuration functionality working, with partial time zone support. If you'd like to try it out:


For Octave 4.4.0 and newer:

pkg install https://github.com/apjanke/octave-addons-chrono/releases/download/v0.1.0/chrono-0.1.0.tar.gz


reply via email to

[Prev in Thread] Current Thread [Next in Thread]