octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: images


From: John W. Eaton
Subject: Re: images
Date: Thu, 15 Feb 2007 04:54:06 -0500

On  9-Feb-2007, Daniel J Sebald wrote:

| The restoring of a colormap in imshow.m probably doesn't make any sence under 
the new scheme, does it?  (Unless we store palettes with individual images.)
| 
| Dan
| --- imshow.m  2007-02-09 04:07:11.000000000 -0600
| +++ imshow_new.m      2007-02-09 05:08:16.807286512 -0600
| @@ -97,7 +97,7 @@
|    ## Set other default parameters.
|    isindexed = false;
|    initial_magnification = 100;
| -  old_colormap = color_map = colormap ();
| +  color_map = colormap ();
|    
|    ## Handle the rest of the arguments.
|    narg = 1;
| @@ -149,9 +149,8 @@
|    dim = ndims (im);
|    if (dim == 2)
|      im = round ((size (color_map, 1) - 1) * im);
| -    colormap (color_map);
|      image (im, initial_magnification/100);
| -    colormap (old_colormap);
| +    colormap (color_map);
|    elseif (dim == 3 && size (im, 3) == 3)
|      __img__ ([] , [], im);
|  ##FIXME NEEDED ANYMORE FOR A SPECIAL CASE?    ## Convert to indexed image.

No, I don't think we need to restore the colormap.

I applied this patch.

Thanks,

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]