[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nmh-workers] mhstore dumps core

From: David Levine
Subject: Re: [Nmh-workers] mhstore dumps core
Date: Fri, 18 Aug 2017 23:43:41 -0400

Ken wrote:

> And dang, coming up with a test for the url external-body type is going
> to be a pain.

Uh, yeah.  I fixed it and now valgrind doesn't report any problems.

> David, do you recall why the clang static analyzer was complaining about
> that?  Also, if you look in all the callers of openExternal() they only
> use the "fd" argument if openExternal returns DONE.

Yes, but those callers return fd.  In this case, there was a path
for output_content_file() in mhstoresbr.c to read its value without
being it having been initialized.  valgrind noticed, too.

Thanks, Norm and Ken.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]