[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nmh-workers] mhstore dumps core

From: Ken Hornstein
Subject: Re: [Nmh-workers] mhstore dumps core
Date: Fri, 18 Aug 2017 18:42:00 -0400

>#1  0x0000000000404427 in openExternal (ct=0x929240,
>    cb=<value optimized out>, ce=0x929f40, file=0x7ffd7a9c8a80,
>    fd=0x7ffd7a9c49fc) at uip/mhparse.c:2342

Alright, a bisection traces this down to commit 337b4e616e8f53ba,
specifically this line added to uipmhparse.c in openExternal():

    *fd = fileno (ce->ce_fp);

(The one before return OK).

David, do you recall why the clang static analyzer was complaining about
that?  Also, if you look in all the callers of openExternal() they only
use the "fd" argument if openExternal returns DONE.  If the issue is
warnings from clang, I think a *fd = -1 at the top of openExternal would
be sufficient.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]