Re: [Nmh-workers] 128 byte field name limit in NAMESZ breaks scan(1)

[Jeffrey C Honig]

Peter Maydell <address@hidden> wrote:

> David Levine wrote:
> >I took a quick look at your dynamic allocation and it looks
> >fine to me
> 
> It hasn't got to me yet, but I had a look at it in the list archive, and
> this line of the patch:
> 
> +                   i +- namebufsiz;
> 
> looks very dubious to me :-)

Good catch.  I haven't tested it yet, I need to make sure it works
properly when entering the realloc code.

> It's also got at least one unrelated change in it:
> +                       if(uprf(cp, "re:") || uprf(cp, "fw:"))

Ah, part of my pending work on generalizing stripping of Re:, another
topic.

> Other than that, it's not as invasive a patch as I'd feared it might be,
> but I still vote to put it on ice until we have some decent tests.

Yes, testing good.

Can the OP send me one of the messages that had issues?

Thanks (谢谢).

Jeff

-- 
Jeffrey C. Honig <address@hidden>
http://www.honig.net/jch
GnuPG ID:14E29E13 <http://www.honig.net/jch/key.shtml>