[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] date selectors using local time for comparison (Ste
From: |
Richard Hopkins |
Subject: |
Re: [Monotone-devel] date selectors using local time for comparison (Stephen Leake) |
Date: |
Tue, 9 Oct 2012 18:46:16 +0100 (BST) |
> That's bad; the user input time should be converted to UTC
> before being
> compared. I thought it was, back when this was added.
>
I've now committed and pushed f7cea8d4e635f311b8c85257b8bfbaf38b961407
which converts the dates into UTC. It works here on Windows and Linux
that I've tried it on (currently 1 hour ahead of UTC). Would be
good to have it tested on other machines though.
> Hm. The tests must set some env variable so all times are
> UTC; that
> would be required for consistency, with testers in several
> time zones.
> But we should have at least one test that sets a different
> time zone, to
> test stuff like this.
>
Agree. Any ideas how we would do that?
- Re: [Monotone-devel] date selectors using local time for comparison (Stephen Leake),
Richard Hopkins <=