monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-devel] Please review nvm.automate_get_roster


From: Thomas Keller
Subject: [Monotone-devel] Please review nvm.automate_get_roster
Date: Mon, 04 Oct 2010 14:32:14 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.11) Gecko/20100714 SUSE/3.0.6 Lightning/1.0b2pre Thunderbird/3.0.6

Please review the above branch. The branch name has not so much in
common with the actual implementation anymore, though:

* a new file_sizes table has been added which records the size
  in bytes of individual files
* two new automate commands have been added, get_file_size returns
  a single recorded file size, get_extended_manifest_of returns
  a format similar to the current roster format, but without the
  local node ids. Additionally, the format prints out the recorded
  file size for each file node
* migration code and tests have been added, some parts of the migration
  code were refactored / expanded
* documentation and NEWS / UPGRADE was updated as well

Since I did the migration pretty late in the process, I realized that
the put_file_sizes_for_revision() method which is used during the
migration could maybe used instead of saving the individual file sizes
on commit, but then again I thought it was cleaner (and faster) to not
have to iterate over the revision object again there.

Let me know what you think,
Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]