monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] [PATCH] to make monotone build on OpenSolaris


From: Zack Weinberg
Subject: Re: [Monotone-devel] [PATCH] to make monotone build on OpenSolaris
Date: Sun, 29 Mar 2009 14:57:38 -0400

2009/3/29 Patrick Georgi <address@hidden>:
>
> - import more stuff from std:: and Botan:: into the globally visible
> namespace
> - clarify method selection for .insert(0,...) where studio isn't sure
> whether that 0 is unsigned int or void* and it has that method for both
> - consistent const attribute for arguments of various methods (studio is
> picky there, too)

These all look safe to me; please go ahead and commit them.  It's a
little disappointing that Sun's compiler doesn't do the special lookup
rule (I can't remember what it's called in the C++ standard) that
means you shouldn't really need those additional using-directives, but
adding them does no harm and makes for less cognitive load on human
readers anyway.

zw




reply via email to

[Prev in Thread] Current Thread [Next in Thread]