|
From: | Zack Weinberg |
Subject: | Re: [Monotone-devel] Review of diff-p branch |
Date: | Tue, 11 Jul 2006 18:38:18 -0700 |
> Not really pointers, just iterators and a lot of complicated > vector-index arithmetic, but see attached; maybe it's clearer? std::vector iterators are pretty thin wrappers around pointers -- have a lot of the same risks. The patch looks fine; I just feel more warm-and-fuzzy when complicated arithmetic is going on, if the assumptions are also documented in code :-). Looks fine to commit.
Done. zw
[Prev in Thread] | Current Thread | [Next in Thread] |