[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Bug in monotone automate inventory

From: Emile Snyder
Subject: Re: [Monotone-devel] Bug in monotone automate inventory
Date: Thu, 27 Oct 2005 12:59:36 -0700

On Thu, 2005-10-27 at 19:57 +0200, Jon Bright wrote:
> Emile Snyder wrote:
> > 
> > No, this is clearly a bug in monotone.  You created a legal file on your
> > system in the working copy, and monotone choked and died.  Thanks for
> > digging and figuring it out,
> An interesting question - should monotone allow you to create any old 
> filename, or should it restrict you to names with half a chance of being 
> cross-platform compatible?  I'd argue for at least the default to be the 
> latter, on the grounds that

I have no real opinion on this point; I was just saying that 'monotone
ls unknown' should *never* die because of the name of any unknown file.
If we can't print some filename as is, then we should escape characters
in some appropriate way (handwaving here).  When you try to 'monotone
add' a file like that, it should perhaps disallow it (with some nicer
error like 'monotone cannot handle control characters in filenames, not
adding filename containing 0x07'), but again, shouldn't dump with an
invariant triggered.


> a) Almost no-one really, really wants that file to be called that (as in 
> this case)
> b) Otherwise, monotone gets to play fun games when it tries to check 
> that file out on a system that doesn't support that as a filename...
> --
> Jon Bright
> Silicon Circus Ltd.

Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]