[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lynx-dev [PATCH 2.8.4dev.20] table overflow

From: Ilya Zakharevich
Subject: lynx-dev [PATCH 2.8.4dev.20] table overflow
Date: Sun, 29 Apr 2001 03:40:57 -0400
User-agent: Mutt/1.2.5i

This patch fixes the last table-related bug I know of: sometimes a
cell would overflow to the right of the visible area (even if line
wrap is requested).

It is a ripe time to remove that silly --enable-nested-tables option.
First of all, it looks like the EXP_NESTED_TABLES #ifdefs are put
"randomly" in the C code - they have very low correlation with
table-in-table code...

Second, it is not proper to disable a feature on the basis that it is
usually present in the pages *simultaneously* with markup which was
giving lynx fits because of absolutely orthogonal reasons.  Especially
if the fits are not triggered any more.  ;-)

(Disabling table-in-table stoped lynx from parsing "more complicated"
tables - which usually contain not only embedded tables, but other
hairy stuff.)


--- ./src/TRSTable.c-pre        Thu Apr 19 15:27:20 2001
+++ ./src/TRSTable.c    Sun Apr 29 00:18:08 2001
@@ -1931,7 +1931,9 @@ PUBLIC int Stbl_finishTABLE ARGS1(
-    return me->ncols;
+    /* need to recheck curpos: though it is checked each time a cell
+       is added, sometimes the result is ignored, as in split_line(). */
+    return (curpos > MAX_STBL_POS ? -1 : me->ncols);
 PUBLIC short Stbl_getAlignment ARGS1(

; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]