Re: [lmi] [PATCH] C++ m11n: range-based for loops

[Vadim Zeitlin]

On Thu, 12 Jan 2017 10:24:22 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2017-01-11 22:39, Vadim Zeitlin wrote:
GC> [...]
GC> >           https://github.com/vadz/lmi/pull/52
GC> [...]
GC> >  Unfortunately, looking at it now, I realize that there are quite a lot of
GC> > changes and it risks taking some time to review it, which I'm not sure you
GC> > have.
GC> 
GC> I'll make the time. This changeset is vast, but fascinating.

 Thanks in advance!

GC> Lastly, on a comic note, at first I thought clang-tidy must have
GC> gotten confused here:
GC> 
GC> -    typedef std::vector<std::string>::const_iterator aut0;
GC> -    for(aut0 i = filenames.begin(); i != filenames.end(); ++i)
GC> +    for(auto const& fn: filenames)
GC> 
GC> because no such name as 'aut0' could possibly exist in lmi...but it
GC> must have been an abbreviation for "authenticity", and I guess in
GC> 2006 I wasn't thinking of 'auto' as a keyword (except as a nearly
GC> forgotten artifact of K&R C).

 Really? I was -- of course -- also confused when reviewing this change,
but then I decided that you must have had used "aut0" as an emulation of
"auto" in C++11 and even thought that it was a fun way of gently mocking
C++98. Have you really not done this on purpose?

VZ