lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] [PATCH] C++ m11n: range-based for loops


From: Vadim Zeitlin
Subject: [lmi] [PATCH] C++ m11n: range-based for loops
Date: Wed, 11 Jan 2017 23:39:49 +0100

 Hello again,

 I didn't wait for the answer to my last question because, after looking at
the patch once again, I realized that there really wasn't much remaining to
do and so I finished updating the last couple of loops, tested everything
(even including the coding rules test this time...) with gcc6 and clang
under Linux and gcc 4.9 under MSW and submitted

                https://github.com/vadz/lmi/pull/52

 As the description of this PR indicates, the first commit (see
https://github.com/vadz/lmi/pull/52/commits/d1fd3ae2e2) contains mostly
changes done automatically by clang-tidy (with a few "auto"s added manually
by me and a few typedefs not necessary any more removed), while the second
one (https://github.com/vadz/lmi/pull/52/commits/6afb131f2d5) contains only
the changes done manually, so while it's smaller, it probably merits more
detailed review.

 Unfortunately, looking at it now, I realize that there are quite a lot of
changes and it risks taking some time to review it, which I'm not sure you
have. But I still hope it can be useful, if only as a base for your own
changes: unlike before, I won't ask you to merge this one a.s.a.p. because
I have no more pending global changes, so the risk of conflicts in the
future should be smaller. I still plan to start using range-based for loops
and auto in the new code now, even if this would make new code inconsistent
with the current master -- but I hope that this will change in the future.

 Please let me know if you have any questions and, as promised, I'll really
stop here with my own C++ m11n changes.
VZ

P.S. Speaking of changes, sorry for the recent flurry of commits to
     autotools build chain, I got really confused by automake/libtool
     use of AR and repeatedly misunderstood how things worked, while,
     and this is the worst part, being sure that I did understand them...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]