[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5324: \abs-fontsize and set-global-staff-size in books (issue
From: |
dak |
Subject: |
Re: Issue 5324: \abs-fontsize and set-global-staff-size in books (issue 341450043 by address@hidden) |
Date: |
Mon, 13 Aug 2018 09:56:50 -0700 |
On 2018/08/13 16:46:59, Be-3 wrote:
On 2018/08/13 16:21:10, lemzwerg wrote:
> LGTM, thanks!
>
>
https://codereview.appspot.com/341450043/diff/1/input/regression/book-change-global-staffsize-abs-fonts.ly
> File input/regression/book-change-global-staffsize-abs-fonts.ly
(right):
>
>
https://codereview.appspot.com/341450043/diff/1/input/regression/book-change-global-staffsize-abs-fonts.ly#newcode6
> input/regression/book-change-global-staffsize-abs-fonts.ly:6:
> @code{\\abs-fontsize}.
> A single-word sentence looks strange...
Right!
(That's a single-word sentence that definitely makes more sense than
"\abs-fontsize."
I'll see to it, thanks.
Apart from that: I just wonder if there's another possibility to
change
output_scale other than by #set-global-staff-size. If so, as DAK
implied, we'd
better go for a more comprehensive solution.
AFAIR, output-scale is changed in \score markups. That changes the
behavior of dimensions in those: I implemented an issue to fix problems
here but I was basically flying blind. Let's see. There is
commit 4343d45b858e21f30e22a9d899163b35e4579dd1
Author: David Kastrup <address@hidden>
Date: Tue Aug 12 20:29:22 2014 +0200
Issue 4065: Don't rescale \layout in \score markup when already
scaled
This change modifies the fix for issue 677 to avoid scaling problems
when employing $(ly:grob-layout grob) in the \layout of a score
markup.
and
commit 84cf69f7c840700a83ca6a9ae9e6b6f2e9f9f1f9
Author: David Kastrup <address@hidden>
Date: Mon Dec 31 18:15:41 2012 +0100
Issue 677: \score markup confuses paper settings
I actually have no idea whether this is the right fix, but it seems
to
do something related to the TODO comments and the issue report.
There is also the issue that layout-set-staff-size is iffish and does
not really yield the same result as global-set-staff-size.
https://codereview.appspot.com/341450043/