[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Case of 'c' in partcombine
From: |
Carl Sorensen |
Subject: |
Re: Case of 'c' in partcombine |
Date: |
Thu, 25 May 2017 15:48:11 +0000 |
User-agent: |
Microsoft-MacOutlook/14.7.3.170325 |
On 5/25/17 8:40 AM, "lilypond-devel on behalf of Charles Winston"
<address@hidden on behalf of
address@hidden> wrote:
>Hey developers,
>
>I am working on my first patch‹it is resolving a very simple issue from
>the tracker. The case of the Œc¹ in partcombine is inconsistent and can
>result in some confusion. For example: \partcombine, \partcombineApart,
>and others like this use the lower-case Œc' Š but
>\partCombineTextsOnNote, \partCombineListener use the camelCase ŒC¹. The
>suggestion is to change all instances of partcombine to the camelCase
>partCombine‹not the other way around because the engraver treats ³part²
>and ³combine² as separate words: ŒPart_combine_engraver¹.
This is an easy patch in terms of functionality, but it will need a
convert-ly rule because it will break existing scores. That's not a
reason to avoid doing it; you just need to be aware that the rule will
need to be made and tested.
>
>I would love some guidance as to where to find all the instances of
>partcombine.
I would do
git grep -i combine
which should find every occurrence of combine, ignoring case. It should
catch all of the things you've identified in your first paragraph.
HTH,
Carl
- Case of 'c' in partcombine, Charles Winston, 2017/05/25
- Re: Case of 'c' in partcombine,
Carl Sorensen <=
- Re: Case of 'c' in partcombine, Charles Winston, 2017/05/25
- Re: Case of 'c' in partcombine, Carl Sorensen, 2017/05/25
- Re: Case of 'c' in partcombine, Charles Winston, 2017/05/25
- Message not available
- Re: Case of 'c' in partcombine, Charles Winston, 2017/05/29
- Re: Case of 'c' in partcombine, David Kastrup, 2017/05/29
- Re: Case of 'c' in partcombine, Charles Winston, 2017/05/29
- Re: Case of 'c' in partcombine, David Kastrup, 2017/05/29
- Re: Case of 'c' in partcombine, Charles Winston, 2017/05/29
- Re: Case of 'c' in partcombine, David Kastrup, 2017/05/29
- Re: Case of 'c' in partcombine, Winston, Charles R., 2017/05/29