lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Remove routing information from Grob_info


From: James Lowe
Subject: Re: [PATCH] Remove routing information from Grob_info
Date: Wed, 27 Apr 2016 07:16:51 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1

Good morning David,

On 25/04/16 16:24, David Kastrup wrote:
It passes information to acknowledgers that does not really belong there and 
instead
manages how information gets there.  Moving this information into arguments for
the various kinds of announce_grob procedure is cleaner and allows to bounce
Grob_info through Scheme without the danger of information loss.
---
  lily/auto-beam-engraver.cc     |  6 ++----
  lily/engraver-group.cc         | 17 +++++++----------
  lily/engraver.cc               |  9 ++++-----
  lily/grob-info.cc              |  4 ----
  lily/include/engraver-group.hh | 15 +++++++++++++--
  lily/include/engraver.hh       |  4 ++--
  lily/include/grob-info.hh      | 17 +++--------------
  lily/include/score-engraver.hh |  2 +-
  lily/score-engraver.cc         |  6 +++---
  lily/span-bar-stub-engraver.cc |  3 +--
  10 files changed, 36 insertions(+), 47 deletions(-)

diff --git a/lily/auto-beam-engraver.cc b/lily/auto-beam-engraver.cc
...

https://sourceforge.net/p/testlilyissues/issues/4834/

P.S. do you still need someone to verify Ubuntu 16 Xenial Xylophones - or whatever it is called - is the root of the issue you are having with git-cl? I may have some spare cycles today.


--
James

-------




reply via email to

[Prev in Thread] Current Thread [Next in Thread]