[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Table Of Contents crash with negative first-page-number (issue 25874
From: |
thomasmorley65 |
Subject: |
Re: Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden) |
Date: |
Sun, 12 Jul 2015 17:49:44 +0000 |
On 2015/07/12 17:01:06, dak wrote:
https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode542
scm/define-markup-commands.scm:542: (+ table-page-number (+ 1 (* -1
first-page-number))))
Uh, (- table-page-number (1- first-page-number)) ?
done
Do the links actually work when first-page-number is, say, 10?
yes
If so, did they
not work before?
No, it was broken.
https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode548
scm/define-markup-commands.scm:548: (ly:stencil-add
What's the reason for delaying this part of the stencil expression as
well?
No reason, corrected.
https://codereview.appspot.com/258740043/
- Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden), thomasmorley65, 2015/07/12
- Re: Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden), dak, 2015/07/12
- Re: Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden),
thomasmorley65 <=
- Re: Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden), dak, 2015/07/12
- Re: Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden), thomasmorley65, 2015/07/12
- Re: Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden), thomasmorley65, 2015/07/12
- Re: Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden), dak, 2015/07/12
- Re: Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden), thomasmorley65, 2015/07/12