Re: Table Of Contents crash with negative first-page-number (issue 258740043 by address@hidden)

[thomasmorley65]

On 2015/07/12 23:39:52, dak wrote:
> On 2015/07/12 17:49:44, thomasmorley651 wrote:
> > On 2015/07/12 17:01:06, dak wrote:
> > >

https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm
> > > File scm/define-markup-commands.scm (right):
> > >
> > >
> >

https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode542
> > > scm/define-markup-commands.scm:542: (+ table-page-number (+ 1 (*
-1
> > > first-page-number))))
> > > Uh, (- table-page-number (1- first-page-number)) ?
> >
> > done

> Now I get second thoughts.  The problem is that I actually have no
clue how this
> calculation comes about.  Is it because logical pages are counted from
1?

If you mean that the pdf's first page is always page 1 of the document
(whatever page-number is printed actually), then yes.

> If so, this likely should rather be (1+ (- table-page-number
first-page-number))
> instead.  Basically, the calculation should reflect the underlying
logic.
> Whatever that may be.

Changed to your proposal.


https://codereview.appspot.com/258740043/