Re: Roman string numbers (issue 145490043 by address@hidden)

[v . villenave]

Thanks James,
since I've been living under a rock for some time, I wasn't aware of the
Google tracker/Rietveld integration. Thanks Colin!

I've slightly reworded your suggestions but hopefully this will be both
concise and clear.


https://codereview.appspot.com/145490043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/changes.tely#newcode65
Documentation/changes.tely:65: (e.g. for unfretted string instruments).
On 2014/09/29 06:30:27, J_lowe wrote:
> 'String numbers can now be printed using Roman numerals.'

> Could we get a small @lilypond example here?

Done.

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/fretted-strings.itely#newcode127
Documentation/notation/fretted-strings.itely:127: than above.
On 2014/09/29 06:30:27, J_lowe wrote:
> This has some awkward syntax. I suggest:

> The default number style, as is customary with unfretted strings, can
be printed
> in Roman numerals and can also be placed below the staff rather than
above.

Done.

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/unfretted-strings.itely
File Documentation/notation/unfretted-strings.itely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/unfretted-strings.itely#newcode118
Documentation/notation/unfretted-strings.itely:118:
On 2014/09/29 06:30:27, J_lowe wrote:
> This could be reduced slightly (and possibly spilt into two paras):

> 'Roman rather than the default circled Arabic numerals can be added as
strings
> numbers.  See @ref{String number indications}.

> Alternatively, open strings can be indicated by using markup commands
with
> articulation scripts.'


Done.

https://codereview.appspot.com/145490043/