[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Roman string numbers (issue 145490043 by address@hidden)
From: |
pkx166h |
Subject: |
Re: Roman string numbers (issue 145490043 by address@hidden) |
Date: |
Mon, 29 Sep 2014 06:30:27 +0000 |
Welcome back Valentine!
P.S. don't forget to update the google tracker (if not using git-cl) -
Patch-New means the patch gets automatic testing.
https://codereview.appspot.com/145490043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/145490043/diff/1/Documentation/changes.tely#newcode65
Documentation/changes.tely:65: (e.g. for unfretted string instruments).
'String numbers can now be printed using Roman numerals.'
Could we get a small @lilypond example here?
https://codereview.appspot.com/145490043/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
https://codereview.appspot.com/145490043/diff/1/Documentation/notation/fretted-strings.itely#newcode127
Documentation/notation/fretted-strings.itely:127: than above.
This has some awkward syntax. I suggest:
The default number style, as is customary with unfretted strings, can be
printed in Roman numerals and can also be placed below the staff rather
than above.
https://codereview.appspot.com/145490043/diff/1/Documentation/notation/unfretted-strings.itely
File Documentation/notation/unfretted-strings.itely (right):
https://codereview.appspot.com/145490043/diff/1/Documentation/notation/unfretted-strings.itely#newcode118
Documentation/notation/unfretted-strings.itely:118:
This could be reduced slightly (and possibly spilt into two paras):
'Roman rather than the default circled Arabic numerals can be added as
strings numbers. See @ref{String number indications}.
Alternatively, open strings can be indicated by using markup commands
with articulation scripts.'
https://codereview.appspot.com/145490043/