[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Die, instrumentSwitch. (issue 133390043 by address@hidden)
|
From: |
davide . liessi |
|
Subject: |
Re: Die, instrumentSwitch. (issue 133390043 by address@hidden) |
|
Date: |
Sun, 31 Aug 2014 22:55:11 +0000 |
https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/staff.itely
File Documentation/notation/staff.itely (right):
https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/staff.itely#newcode967
Documentation/notation/staff.itely:967: along with other settings as
neded for the new instrument.
neded -> needed
https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/staff.itely#newcode972
Documentation/notation/staff.itely:972: prepPiccolo =
<>^\markup\italic\line{"muta in Piccolo"}
Is '\line' needed here? I think that it can be omitted.
The same for 'prepFlute' at line 982.
Also, for coding style uniformity with the other '\markup...' commands
in this patch set, maybe this should be written '\markup { \italic "muta
in Piccolo" }', and similarly for lines 978, 982 and 988.
https://codereview.appspot.com/133390043/