lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 3299: better alignment with PaperColumn parent (issue 13228004


From: dak
Subject: Re: Issue 3299: better alignment with PaperColumn parent (issue 132280043 by address@hidden)
Date: Wed, 27 Aug 2014 22:01:03 +0000

On 2014/08/27 21:23:59, janek wrote:
Please review.  I hope that the regtest (see output here
https://code.google.com/p/lilypond/issues/detail?id=3299#c9) and
commit message
are clear.

best,
Janek

The commit message is totally unclear.  It describes why aligning to
different objects cannot possibly lead to the same result.  Then it
"introduces a placeholder extent" (placeholder for what?) "used for
aligning such grobs" (for aligning _what_ grobs? to which grobs?).  How
is the placeholder extent used for aligning grobs?  How can this commit
"fix" that different alignment points are different?

https://codereview.appspot.com/132280043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]