Re: Fix clef transposition alignment (issue 3186) (issue 8363044)

[janek . lilypond]

https://codereview.appspot.com/8363044/diff/6001/input/regression/clef-transposition-placement.ly
File input/regression/clef-transposition-placement.ly (right):

https://codereview.appspot.com/8363044/diff/6001/input/regression/clef-transposition-placement.ly#newcode21
input/regression/clef-transposition-placement.ly:21: \override
Staff.Clef.full-size-change = ##t
On 2014/08/16 22:23:38, dak wrote:
> This syntax is not version 2.16.0 as declared above

Done.

https://codereview.appspot.com/8363044/diff/6001/lily/clef-modifier.cc
File lily/clef-modifier.cc (right):

https://codereview.appspot.com/8363044/diff/6001/lily/clef-modifier.cc#newcode42
lily/clef-modifier.cc:42: me->get_property ("clef-alignments"));
On 2014/08/16 22:23:38, dak wrote:
> Up to this point there is not exactly a fabulous amount of
crash-proneness in
> case of non-standard clef layout.  The code does not seem particularly
prepared
> to deal with a clef like varC.

I'm not sure what you mean by "crash-proneness in case of non-standard
clef layout".  The code is supposed to center-align the ClefModifier if
there is no detailed alignment provided for a given clef, and as far as
i can see this works.  However, i agree that taking the 1-letter
substring is not the most elegant thing; i could change that.

> Why would the table clef-alignments be stored in a context property?
It does
> not seem to be context dependent.

You mean clef-alignments should be defined as a kind of a global
variable, someplace like in output-lib.scm?  Ok, this could be done like
that - however, i didn't find how such Scheme-defined global variables
can be accessed from C++.  Pointer, please?

https://codereview.appspot.com/8363044/